Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error paginating after new comment insertion #2

Closed
johnnyoshika opened this issue Jan 18, 2020 · 0 comments
Closed

Error paginating after new comment insertion #2

johnnyoshika opened this issue Jan 18, 2020 · 0 comments

Comments

@johnnyoshika
Copy link
Owner

When paginating after a new comment is inserted, and when the newly inserted comment returns from the server through pagination, this results in an ID conflict:
image
This also results in a duplicate comment, even through they have the same ID.

To reproduce:

  • Insert a new comment
  • Keep clicking More Comments until the newly inserted comment appears a second time

This issue was highlighted in this PR: the-road-to-graphql/react-graphql-github-apollo#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant