Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save gas when editing offer by only overriding amount #18

Merged
merged 2 commits into from
Sep 9, 2024
Merged

save gas when editing offer by only overriding amount #18

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c75397
save gas when editing offer by only overriding amount
aazhou1 Sep 6, 2024
321219c
Merge branch 'master' into edit-offer-gas-savings
aazhou1 Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/Strategy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,12 +922,8 @@ contract Strategy is BaseStrategy, Pausable, ReentrancyGuard {
);
} else {
// Edit offer, overwrite existing
termAuctionListData.offers[offerIds[0]] = PendingOffer({
repoToken: repoToken,
offerAmount: offer.amount,
termAuction: auction,
offerLocker: offerLocker
});
PendingOffer storage pendingOffer = termAuctionListData.offers[offerIds[0]];
pendingOffer.offerAmount = offer.amount;
}
}

Expand Down
Loading