Fixing strategy tests

[0xddong]

Summary by CodeRabbit

• New Features

  • Enhanced clarity in liquidity and reserve terminology within the Strategy contract.
  • Introduced a new test function to validate auction offers against concentration limits.

• Bug Fixes

  • Updated error handling and validation logic to reflect new terminology and improve functionality.

• Documentation

  • Renamed functions and events to align with revised terminology, ensuring better understanding for developers.

• Tests

  • Updated tests to accommodate changes in function signatures and validate new logic related to concentration limits.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The recent changes enhance the clarity and functionality of the Strategy, TermVaultEventEmitter, and related contracts by renaming key variables and functions to align with updated reserve terminology. Error handling and internal logic have been refined, ensuring improved accuracy in liquidity calculations and governance processes. New event emissions and test cases reinforce these updates, promoting better understanding and validation of the contract's logic.

Changes

Files	Change Summary
src/Strategy.sol, src/TermVaultEventEmitter.sol, src/interfaces/term/ITermVaultEvents.sol	Key variables and functions were renamed to shift focus from liquidity reserve ratios to required reserve ratios. This includes updates to error handling and event emissions reflecting the new terminology.
src/test/TestUSDCSellRepoToken.t.sol, src/test/TestUSDCSubmitOffer.t.sol	Test contracts were updated to align with new function signatures and add new tests for concentration limits, improving the robustness of the testing framework.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Strategy
    participant VaultEventEmitter
    participant RepoToken
    
    User->>Strategy: setRequiredReserveRatio(newRatio)
    Strategy->>VaultEventEmitter: emitRequiredReserveRatioUpdated(oldRatio, newRatio)
    VaultEventEmitter->>User: Confirmation of Update

    User->>Strategy: simulateTransaction(repoToken, amount)
    Strategy->>RepoToken: Validate transaction
    RepoToken-->>Strategy: Transaction result
    Strategy-->>User: Return simulatedLiquidityRatio

Loading

🐇 Hop along the code, oh what a sight!
New names and functions, all feeling just right!
From liquidity to reserves, we make it clear,
With updates and tests, we have nothing to fear!
Celebrate the changes, let’s give a cheer,
For clarity and logic, our vision is near! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.