128 list add category name in page title #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we have an anti-pattern about how data is fetch.
It would be better to do data fetching on page level and then propagate them through props or store (in order to avoid props drilling in case we have too much depth between page and last component).
Components would be used for UI only, all the logic resides on higher level. It will give us more scalability and easy of maintenance. As of today we have data fetching a bit everywhere which make it hard to understand and brings rendering issues.
I think we have to think Components as dumb pieces of code, which renders a small piece of layout with the data given in props.