Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[list] Add category name in page title #128

Closed
frodrigo opened this issue Aug 2, 2023 · 1 comment · Fixed by #154
Closed

[list] Add category name in page title #128

frodrigo opened this issue Aug 2, 2023 · 1 comment · Fixed by #154
Assignees
@wazolab
Labels
bug Something isn't working
Milestone
v1.22

Comments

@frodrigo
Copy link
Member

frodrigo commented Aug 2, 2023

It is not so easy. Because the id can be a ref.

    useHead(headerFromSettings(settings.value, {
      title: menuItems.value?.find((menuItem) => `${menuItem.id}` == (params.id as string))?.category?.name.fr
    }))
@frodrigo frodrigo added the bug Something isn't working label Aug 2, 2023
@frodrigo frodrigo added this to the v1.22 milestone Jan 10, 2024
@wazolab
Copy link
Member

wazolab commented Jan 10, 2024 •
edited
Loading

The page's meta title isn't in sync with Category's title

wazolab added a commit that referenced this issue Feb 5, 2024
@wazolab
fix: display category name in tab title #128
b6d3bad
wazolab added a commit that referenced this issue Feb 6, 2024
@wazolab
fix: update category page title on category change #128
d6e43ae
wazolab added a commit that referenced this issue Feb 6, 2024
@wazolab
fix: update category page title on category change #128
e5d604e
@wazolab wazolab linked a pull request Feb 6, 2024 that will close this issue
128 list add category name in page title #154
Merged
frodrigo pushed a commit that referenced this issue Feb 6, 2024
@wazolab
list add category name in page title #128
652c100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wazolab wazolab

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.22
Development

Successfully merging a pull request may close this issue.

128 list add category name in page title teritorio/vido
2 participants
@frodrigo @wazolab