Implement Cluster CoreCoord API #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanevskiTT
requested review from
patrickroberts,
abhullar-tt,
broskoTT and
tt-vjovanovic
pjanevskiTT
force-pushed
the
pjanevski/core_coord_api
branch
from
1d8d2b5 to
f9833cd
Compare
pgkeller
reviewed
Dec 16, 2024
broskoTT
approved these changes
Dec 16, 2024
abhullar-tt
reviewed
Dec 16, 2024
1 task
pjanevskiTT
force-pushed
the
pjanevski/core_coord_api
branch
3 times, most recently
from
fc5735d to
fc407bc
Compare
pjanevskiTT
force-pushed
the
pjanevski/core_coord_api
branch
7 times, most recently
from
998893a to
cf27226
Compare
broskoTT
approved these changes
Dec 20, 2024
pjanevskiTT
force-pushed
the
pjanevski/core_coord_api
branch
from
c3f0293 to
1bd57f2
Compare
This was referenced Dec 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#220)
Description
Provide Cluster API with CoreCoord. Every function that was expecting virtual coordinates has the same function just with CoreCoord structure. Old API is still there just to not break tt-metal and tt-lens at the moment. When the clients have switched to the new API we can delete the old one. In the meantime, internals of Cluster can be redesigned in parallel with client work on switching to new API. So this should be a two phase change. This is the first one where the new API is added, and when clients have switched to the new API second phase will be deleting the old API
List of the changes
Testing
UMD unit tests
API Changes
Old API is still there, so no API changes at the moment