-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLB Manager #420
TLB Manager #420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how the PR moves TLB logic from cluster downwards (Chip, TTDevice), but I think it is not in the right place in the layering. We can discuss this offline and get back to moving this if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few API comments, changes look great now
c97e03a
to
3b17ff5
Compare
Issue
Related to #417
Description
Introduction into TLB manager class. This class should hold maps between tlb indexes and cores, and should hand out tlb_indicies. This might not be completelly true after this PR, which was more focused on getting things out from cluster.cpp file. But not too much stuff.
List of the changes
Testing
Existing CI tests should cover this class.
Will try to add additional TLBManager focused tests.
API Changes
There are no API changes in this PR.