Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soc descriptor API with CoreCoord #387

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Soc descriptor API with CoreCoord #387

merged 1 commit into from
Dec 16, 2024

Conversation

pjanevskiTT
Copy link
Contributor

Issue

/

Description

Integrate CoreCoord struct into tt_SocDescriptor class

List of the changes

  • Expose new API with CoreCoord through Soc descriptor
  • Test custom soc descriptor
  • Implement functions to get cores and grid size
  • Implement functions to get harvested cores and grid size

Testing

Unit test

API Changes

No API changes. API is the same, implementations have changed

@pjanevskiTT pjanevskiTT force-pushed the pjanevski/tt_soc_descriptor_api branch 3 times, most recently from 1d7a0ed to 882bfa5 Compare December 10, 2024 10:41
broskoTT
broskoTT approved these changes Dec 10, 2024
View reviewed changes
device/api/umd/device/tt_soc_descriptor.h Show resolved Hide resolved
device/wormhole/wormhole_coordinate_manager.cpp Outdated Show resolved Hide resolved
device/api/umd/device/tt_soc_descriptor.h Outdated Show resolved Hide resolved
device/tt_soc_descriptor.cpp Outdated Show resolved Hide resolved
device/coordinate_manager.cpp Outdated Show resolved Hide resolved
@pjanevskiTT pjanevskiTT force-pushed the pjanevski/coord_manager_impl branch 3 times, most recently from f93ee94 to 8e69799 Compare December 10, 2024 15:47
@pjanevskiTT pjanevskiTT force-pushed the pjanevski/coord_manager_impl branch from 540cf7a to 51ee2e5 Compare December 11, 2024 16:17
@pjanevskiTT pjanevskiTT force-pushed the pjanevski/tt_soc_descriptor_api branch 3 times, most recently from 3283ef9 to fc89b2e Compare December 11, 2024 16:37
Base automatically changed from pjanevski/coord_manager_impl to main December 11, 2024 17:28
@pjanevskiTT pjanevskiTT force-pushed the pjanevski/tt_soc_descriptor_api branch 6 times, most recently from d45d99f to b55a31e Compare December 16, 2024 10:01
@pjanevskiTT pjanevskiTT force-pushed the pjanevski/tt_soc_descriptor_api branch from b55a31e to 883edcd Compare December 16, 2024 10:13
@pjanevskiTT pjanevskiTT self-assigned this Dec 16, 2024
@pjanevskiTT pjanevskiTT merged commit 85bf5c4 into main Dec 16, 2024
24 checks passed
@pjanevskiTT pjanevskiTT deleted the pjanevski/tt_soc_descriptor_api branch December 16, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broskoTT broskoTT broskoTT approved these changes

@tt-vjovanovic tt-vjovanovic tt-vjovanovic approved these changes

Assignees

@pjanevskiTT pjanevskiTT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjanevskiTT @broskoTT @tt-vjovanovic