Fix flatc tt_metal build #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fix issue after #358
Description
This change creates problems on clang-tidy run on tt_metal.
List of the changes
Testing
Both bellow branches and runs have detect_arch commit reverted on UMD, and have "don't run clang-tidy" commit reverted on tt_metal
All post commit run on tt_metal prior to change: https://github.com/tenstorrent/tt-metal/actions/runs/12177536236
All post commit run on tt_metal after change: https://github.com/tenstorrent/tt-metal/actions/runs/12177582506
API Changes
There are no API changes in this PR.
Note that "build client" job failure is expected due to this PR not being checked in: tenstorrent/tt-metal#15564