Skip to content

Commit

Permalink
Fix flatc tt_metal build (#371)
Browse files Browse the repository at this point in the history
### Issue
Fix issue after #358 

### Description
This change creates problems on clang-tidy run on tt_metal.

### List of the changes
- Reverted part of change from referenced PR

### Testing
Both bellow branches and runs have detect_arch commit reverted on UMD,
and have "don't run clang-tidy" commit reverted on tt_metal
All post commit run on tt_metal prior to change:
https://github.com/tenstorrent/tt-metal/actions/runs/12177536236
All post commit run on tt_metal after change:
https://github.com/tenstorrent/tt-metal/actions/runs/12177582506

### API Changes
There are no API changes in this PR.

Note that "build client" job failure is expected due to this PR not
being checked in: tenstorrent/tt-metal#15564
  • Loading branch information
broskoTT authored Dec 5, 2024
1 parent dc5e371 commit a98ddd2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions cmake/dependencies.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ function(fetch_dependencies)
"FLATBUFFERS_STRICT_MODE ON"
)

set(FLATC_EXE ${flatbuffers_BINARY_DIR}/flatc PARENT_SCOPE)

###################################################################################################################
# libuv (for process management)
###################################################################################################################
Expand Down
2 changes: 1 addition & 1 deletion device/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ add_custom_command(
OUTPUT
${FBS_GENERATED_HEADER}
COMMAND
${FLATC_EXE}
flatc
ARGS
--cpp -o "${CMAKE_CURRENT_BINARY_DIR}/" ${FBS_FILE}
DEPENDS
Expand Down

0 comments on commit a98ddd2

Please sign in to comment.