Refactor types #357
Merged
Refactor types #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
broskoTT
commented
Nov 30, 2024
pjanevskiTT
reviewed
Dec 2, 2024
broskoTT
commented
Dec 3, 2024
pjanevskiTT
approved these changes
Dec 3, 2024
broskoTT
force-pushed
the
brosko/ttarch
branch
from
36a9f13 to
73d5507
Compare
10 tasks
more fixes, revert some changes more refactorings minor arch to tt fix after rebase revert Arch to ARCH
broskoTT
force-pushed
the
brosko/ttarch
branch
from
eafd170 to
c422ccc
Compare
broskoTT
added a commit
to tenstorrent/tt-metal
that referenced
this pull request
Dec 8, 2024
### Ticket All related to #13948 ### Problem description Some api header files have been moved around in UMD repo. UMD PR: tenstorrent/tt-umd#357 ### What's changed - umd/device/tt_arch_type.h -> umd/device/types/arch.h - umd/device/tt_cluster_descriptor_types.h -> umd/device/types/cluster_descriptor_types.h - umd/device/xy_pair.h -> umd/device/types/xy_pair.h - get_arch_str -> tt::arch_to_str ### Checklist - [x] All post-commit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12224723517 - [x] Blackhole post-commit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12224723937 - [x] (Single-card) Model perf tests : https://github.com/tenstorrent/tt-metal/actions/runs/12224724459 - [ ] (Single-card) Device perf regressions : https://github.com/tenstorrent/tt-metal/actions/runs/12224725026 - [x] (T3K) T3000 unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12224725640 - [x] (T3K) T3000 demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12224726199 - [x] (TG) TG unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12224726548 - [x] (TG) TG demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12224726936 - [x] (TGG) TGG unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12224727791 - [x] (TGG) TGG demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12224728493
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Related to #103
Description
Reformat ARCH into tt::umd::Arch
While at it, I looked at other types, and realised that cluster_types are a thing.
And now we have 3 or 4 different type files, so this warrants a dedicated folder for these small types.
List of the changes
Following changes will be
Testing
Code builds in existing CI tests.
API Changes
This PR has API changes: