detect_arch in ClusterDescriptor #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanevskiTT
reviewed
Nov 27, 2024
broskoTT
force-pushed
the
brosko/cluster_desc_no_yaml
branch
from
a61e27a to
87308c9
Compare
broskoTT
force-pushed
the
brosko/detect_arch
branch
from
86084ea to
c1aa35c
Compare
broskoTT
force-pushed
the
brosko/detect_arch
branch
from
c1aa35c to
a17dd0a
Compare
pjanevskiTT
approved these changes
Nov 29, 2024
This was referenced Nov 29, 2024
Merged
broskoTT
added a commit
to tenstorrent/tt-metal
that referenced
this pull request
Dec 5, 2024
### Ticket Related to #13948 ### Problem description detect_arch was in the global namespace. Now putting this functionality in the right place. It also now works with logical ids, as opposed to pci device enumeration id. Related UMD change tenstorrent/tt-umd#345 ### What's changed Changed detect_arch to tt_ClusterDescriptor::get_arch() BoardType::DEFAULT changed to UNKNOWN Also changed detect_arch to PCIDevice::enumerate_devices_info(), due to ClusterDescriptor::create() not working. ### Checklist - [x] All post-commit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12139731818 - [x] Blackhole post-commit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12139733483 - [ ] (Single-card) Model perf tests : https://github.com/tenstorrent/tt-metal/actions/runs/12139735518 - [x] (Single-card) Device perf regressions : https://github.com/tenstorrent/tt-metal/actions/runs/12139737448 - [x] (T3K) T3000 unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12139739342 - [x] (T3K) T3000 demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12139741041 - [x] (TG) TG unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12139742806 - [x] (TG) TG demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12139744773 - [ ] (TGG) TGG unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12139746353 - [x] (TGG) TGG demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12139748257 - [x] All post-commit tests on last commit: https://github.com/tenstorrent/tt-metal/actions/runs/12178722655
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Related to #99
Aftermath of #175
Description
Make detect_arch available through cluster_descriptor which should be the only real endpoint when reading information about chips in the cluster.
List of the changes
Testing
Wrote a test which verifies this works as intended
API Changes
This PR has API changes: