Cluster descriptor create without yaml #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanevskiTT
approved these changes
Nov 26, 2024
5 tasks
|
Don't want to edit your description directly, can you add that this PR solves #295 as well? |
broskoTT
force-pushed
the
brosko/cluster_desc_no_yaml
branch
from
98127f8 to
a61e27a
Compare
broskoTT
force-pushed
the
brosko/cluster_desc_no_yaml
branch
from
a61e27a to
87308c9
Compare
5 tasks
broskoTT
added a commit
to tenstorrent/tt-metal
that referenced
this pull request
Nov 29, 2024
### Ticket Related to #13948 ### Problem description Related to UMD change tenstorrent/tt-umd#333 ### What's changed - Remove cluster descriptor path from Cluster's constructor. ### Checklist - [x] Post commit CI passes: https://github.com/tenstorrent/tt-metal/actions/runs/12081012971 - [x] Blackhole Post commit: https://github.com/tenstorrent/tt-metal/actions/runs/12081017393 - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [ ] New/Existing tests provide coverage for changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Finally completes #99
Also solves #295
Description
Allows cluster descriptor yaml to not even be surfaced outside of UMD
List of the changes
Testing
Code builds + CI tests
API Changes
This PR has API changes: