Remove ClusterDescriptor path from constructor #15554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broskoTT
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
2 tasks
abhullar-tt
approved these changes
Nov 28, 2024
broskoTT
added a commit
to tenstorrent/tt-umd
that referenced
this pull request
Nov 29, 2024
### Issue Finally completes #99 Also solves #295 ### Description Allows cluster descriptor yaml to not even be surfaced outside of UMD ### List of the changes - Added tt_ClusterDescriptor::create() which combines - Moved constructor to private, since it shouldn't be used - Renamed ndesc to cluster_desc - Removed cluster_descriptor_path from arguments on one of the constructors of Cluster ### Testing Code builds + CI tests ### API Changes This PR has API changes: - [x] tt_metal PR: tenstorrent/tt-metal#15554 - [ ] tt_debuda PR: tenstorrent/tt-lens#200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Related to #13948
Problem description
Related to UMD change tenstorrent/tt-umd#333
What's changed
Checklist