Refactor our CI yamls

.github/workflows/on-pr-opt.yml → .github/workflows/build-and-run-all-tests.yml

@@ -1,10 +1,12 @@
-# Optional PR checks
-name: On PR - Optional
+# Build and then run all tests, on all supported archs.
+name: Build and run all tests
 
 on:
   workflow_dispatch:
   pull_request:
     branches: ["main"]
+  push:
+    branches: ["main"]
 
 jobs:
   build-tests:

.github/workflows/build-device.yml

@@ -1,19 +1,19 @@
 # Builds device.
 # Build is performed on all supported OS versions.
-name: Build Target
+name: Build Device
 
 on:
-  workflow_call:
-    inputs:
-      timeout:
-        required: true
-        type: number
   workflow_dispatch:
     inputs:
       timeout:
         required: true
-        description: 'The timeout for the build job in minutes'
+        description: 'The timeout for the job in minutes'
         type: number
+        default: 15
+  pull_request:
+    branches: ["main"]
+  push:
+    branches: ["main"]
 
 env:
   BUILD_TARGET: device
@@ -25,7 +25,9 @@ env:
 
 jobs:
   build:
-    timeout-minutes: ${{ inputs.timeout }}
+    # Due to parsing bug, fromJSON is used to convert string to number.
+    # In pull_request or push events, the input context is not available, stating the default again here.
+    timeout-minutes: ${{ fromJSON(inputs.timeout || '15') }}
     strategy:
       fail-fast: false
       matrix:

.github/workflows/build-image.yml

@@ -3,11 +3,17 @@ name: Build and Publish Docker Image
 
 on:
   workflow_dispatch:
-  workflow_call:
+    inputs:
+      timeout:
+        required: true
+        description: 'The timeout for the job in minutes'
+        type: number
+        default: 15
 
 jobs:
   build:
-    timeout-minutes: 15
+    # Due to parsing bug, fromJSON is used to convert string to number
+    timeout-minutes: ${{ fromJSON(inputs.timeout) }}
     strategy:
       fail-fast: false
       matrix:

.github/workflows/build-tests.yml

@@ -37,7 +37,8 @@ env:
 
 jobs:
   build:
-    timeout-minutes: ${{ inputs.timeout }}
+    # Due to parsing bug, fromJSON is used to convert string to number
+    timeout-minutes: ${{ fromJSON(inputs.timeout) }}
     strategy:
       fail-fast: false
       matrix:

.github/workflows/pre-commit.yml

@@ -2,8 +2,11 @@
 name: Run Pre-commit Hooks
 
 on:
-  workflow_call:
   workflow_dispatch:
+  pull_request:
+    branches: ["main"]
+  push:
+    branches: ["main"]
 
 jobs:
   pre-commit:

.github/workflows/run-tests.yml

@@ -45,7 +45,8 @@ env:
 
 jobs:
   test:
-    timeout-minutes: ${{ inputs.timeout }}
+    # Due to parsing bug, fromJSON is used to convert string to number
+    timeout-minutes: ${{ fromJSON(inputs.timeout) }}
     strategy:
       fail-fast: false
       matrix:

.github/workflows/test-runner.yaml

@@ -2,10 +2,17 @@ name: Check runner
 
 on:
   workflow_dispatch:
+    inputs:
+      timeout:
+        required: true
+        description: 'The timeout for the job in minutes'
+        type: number
+        default: 10
 
 jobs:
   check-runners-host:
-    timeout-minutes: 10
+    # Due to parsing bug, fromJSON is used to convert string to number
+    timeout-minutes: ${{ fromJSON(inputs.timeout) }}
     strategy:
       fail-fast: false
       matrix:
@@ -52,7 +59,8 @@ jobs:
           du -h --max-depth=1 | sort -rh
 
   check-runners-docker:
-    timeout-minutes: 10
+    # Due to parsing bug, fromJSON is used to convert string to number
+    timeout-minutes: ${{ fromJSON(inputs.timeout) }}
     strategy:
       fail-fast: false
       matrix: