Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor our CI yamls #319

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Refactor our CI yamls #319

merged 4 commits into from
Nov 21, 2024

Conversation

broskoTT
Copy link
Contributor

@broskoTT broskoTT commented Nov 21, 2024

Issue

No current issue, related to already closed #45

Description

As we're using CI for some time, I found that it actually brings unnecessary complications to have a layer of yamls just designating what is done on pr, optionally on pr, and on push. This can be directly added to each of the jobs.

Another effect is that in the "Actions" tab, we won't have On PR, Optional On PR, and On Push where each includes several different jobs. We will now have Build device, build and run tests, and pre-commit , which will run both on PR branches and main.

List of the changes

  • Created a build-and-run-all-tests.yml which wraps build-tests and run-tests for all archs. This just nicely corresponds exactly to previous on-pr-opt.
  • Deleted on-pr, on-pr-opt and on-push ymls
  • Added to all referenced .ymls the config to run on pr and/or on push, so that same jobs are called on same triggers.
  • Added timeout parameter to a couple of jobs.
  • I will change in settings which jobs are mandatory, if they are now named slightly different.

Testing

CI passes on this PR

API Changes

There are no API changes in this PR.

@broskoTT broskoTT merged commit 5e4f52a into main Nov 21, 2024
19 checks passed
@broskoTT broskoTT deleted the brosko/ci_refactor branch November 21, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Work on adding CI to umd repo
2 participants