create_for_grayskull_cluster -> create_mock_cluster #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanevskiTT
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Looks good. Do we have any actual tests for this, maybe @vtangTT can provide something
|
Just FYI that I just uncovered last night that simulator was broken on the metal level due to changes made in this tenstorrent/tt-metal#14945. Is there a branch with related metal changes? I want to see if this fixes the simulator problem. |
|
Could you try and bisect the commits to see which one breaks the simulator? Not really sure there is a branch with related metal changes. So far uplift strategy was to uplift everything that changes the API plus Almeet uplifts some things that are useful for metal when there is some change inside UMD. If you can pinpoint the commit maybe we can debug it together |
broskoTT
force-pushed
the
brosko/grays-mock
branch
from
8360255 to
faa8155
Compare
|
I have a small change to fix for simulator. Is it ok if I push to your branch @broskoTT On the note of future verification/testing for changes that could affect simulator, I'm trying to setup a pipeline for it on the gitlab side (actually how I found out it was broken in the first place) |
broskoTT
commented
Nov 21, 2024
5 tasks
broskoTT
added a commit
to tenstorrent/tt-metal
that referenced
this pull request
Nov 22, 2024
### Ticket Related to #13948 ### Problem description Tied to UMD change tenstorrent/tt-umd#310 ### What's changed - Rename and clear up create_for_grayskull_cluster to create_mock_cluster - For grayskull, the CEM already works, and the create_from_yaml path is successfully used already ### Checklist - [x] Post commit CI passes : https://github.com/tenstorrent/tt-metal/actions/runs/11972671759 - [x] Blackhole Post commit (if applicable): Not applicable - [x] Model regression CI testing passes (if applicable): Not applicable - [x] Device performance regression CI testing passes (if applicable): Not applicable - [x] New/Existing tests provide coverage for changes: Not applicable
broskoTT
added a commit
to tenstorrent/tt-metal
that referenced
this pull request
Nov 24, 2024
### Ticket Related to #13948 ### Problem description Tied to UMD change tenstorrent/tt-umd#310 ### What's changed - Rename and clear up create_for_grayskull_cluster to create_mock_cluster - For grayskull, the CEM already works, and the create_from_yaml path is successfully used already ### Checklist - [x] Post commit CI passes : https://github.com/tenstorrent/tt-metal/actions/runs/11972671759 - [x] Blackhole Post commit (if applicable): Not applicable - [x] Model regression CI testing passes (if applicable): Not applicable - [x] Device performance regression CI testing passes (if applicable): Not applicable - [x] New/Existing tests provide coverage for changes: Not applicable
10 tasks
broskoTT
added a commit
to tenstorrent/tt-metal
that referenced
this pull request
Nov 26, 2024
### Ticket Related to #13948 ### Problem description Tied to UMD change tenstorrent/tt-umd#310 ### What's changed - Rename and clear up create_for_grayskull_cluster to create_mock_cluster - For grayskull, the CEM already works, and the create_from_yaml path is successfully used already ### Checklist - [x] Post commit CI passes : https://github.com/tenstorrent/tt-metal/actions/runs/11972671759 - [x] Blackhole Post commit (if applicable): Not applicable - [x] Model regression CI testing passes (if applicable): Not applicable - [x] Device performance regression CI testing passes (if applicable): Not applicable - [x] New/Existing tests provide coverage for changes: Not applicable
broskoTT
added a commit
to tenstorrent/tt-metal
that referenced
this pull request
Nov 26, 2024
This is PR similar to #15301. It previously broke CI pipelines, but this PR has a fix for that. ### Ticket Related to #13948 ### Problem description Tied to UMD change tenstorrent/tt-umd#310 ### What's changed - Rename and clear up create_for_grayskull_cluster to create_mock_cluster - For grayskull, the CEM already works, and the create_from_yaml path is successfully used already - eth_coord_t was updated in tenstorrent/tt-umd#306 , there is a change on how PhysicalCoordinate is created to reflect that. ### Checklist - [x] All post-commit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033347997 - [x] Blackhole post-commit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033347995 - [ ] (Single-card) Model perf tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033439959 - [ ] (Single-card) Device perf regressions : https://github.com/tenstorrent/tt-metal/actions/runs/12033442095 - [x] (T3K) T3000 unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033456773 - [x] (T3K) T3000 demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033517770 - [x] (TG) TG unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033520415 - [x] (TG) TG demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033522422 - [x] (TGG) TGG unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033524632 - [x] (TGG) TGG demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033526704
gfengTT
pushed a commit
to tenstorrent/tt-metal
that referenced
this pull request
Nov 27, 2024
This is PR similar to #15301. It previously broke CI pipelines, but this PR has a fix for that. ### Ticket Related to #13948 ### Problem description Tied to UMD change tenstorrent/tt-umd#310 ### What's changed - Rename and clear up create_for_grayskull_cluster to create_mock_cluster - For grayskull, the CEM already works, and the create_from_yaml path is successfully used already - eth_coord_t was updated in tenstorrent/tt-umd#306 , there is a change on how PhysicalCoordinate is created to reflect that. ### Checklist - [x] All post-commit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033347997 - [x] Blackhole post-commit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033347995 - [ ] (Single-card) Model perf tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033439959 - [ ] (Single-card) Device perf regressions : https://github.com/tenstorrent/tt-metal/actions/runs/12033442095 - [x] (T3K) T3000 unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033456773 - [x] (T3K) T3000 demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033517770 - [x] (TG) TG unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033520415 - [x] (TG) TG demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033522422 - [x] (TGG) TGG unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033524632 - [x] (TGG) TGG demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033526704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Contributes to #99 , and a continuation of #280
Description
This function is now only used for creating a cluster descriptor for simulation or mockup environment. Changing accordingly.
List of the changes
Testing
Code builds.
API Changes
This PR has API changes: