UMD create_mock_cluster and fix PhysicalCoordinate #15411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broskoTT
commented
Nov 24, 2024
broskoTT
requested review from
cfjchu,
aliuTT,
tt-asaigal,
omilyutin-tt,
abhullar-tt,
pgkeller,
tt-aho,
tt-dma and
ubcheema
as code owners
abhullar-tt
approved these changes
Nov 25, 2024
aliuTT
requested changes
Nov 25, 2024
aliuTT
approved these changes
Nov 25, 2024
cfjchu
approved these changes
Nov 25, 2024
broskoTT
added a commit
to tenstorrent/tt-umd
that referenced
this pull request
Nov 26, 2024
### Issue No issue ### Description Related to tenstorrent/tt-metal#15411 While working on it, I realised that cluster_id can take whichever chip_id. This change makes it deterministic, and choose always the smallest one ### List of the changes - Always chose smallest number in set for cluster_id - Wrote a test which failed before this change - Minor other changes in test to make it not segfault on machine without cards. ### Testing Wrote a new CI test ### API Changes There are no API changes in this PR.
### Ticket Related to #13948 ### Problem description Tied to UMD change tenstorrent/tt-umd#310 ### What's changed - Rename and clear up create_for_grayskull_cluster to create_mock_cluster - For grayskull, the CEM already works, and the create_from_yaml path is successfully used already ### Checklist - [x] Post commit CI passes : https://github.com/tenstorrent/tt-metal/actions/runs/11972671759 - [x] Blackhole Post commit (if applicable): Not applicable - [x] Model regression CI testing passes (if applicable): Not applicable - [x] Device performance regression CI testing passes (if applicable): Not applicable - [x] New/Existing tests provide coverage for changes: Not applicable
broskoTT
force-pushed
the
brosko/umd_fix
branch
from
e7bddaa to
d35f6a6
Compare
gfengTT
pushed a commit
that referenced
this pull request
Nov 27, 2024
This is PR similar to #15301. It previously broke CI pipelines, but this PR has a fix for that. ### Ticket Related to #13948 ### Problem description Tied to UMD change tenstorrent/tt-umd#310 ### What's changed - Rename and clear up create_for_grayskull_cluster to create_mock_cluster - For grayskull, the CEM already works, and the create_from_yaml path is successfully used already - eth_coord_t was updated in tenstorrent/tt-umd#306 , there is a change on how PhysicalCoordinate is created to reflect that. ### Checklist - [x] All post-commit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033347997 - [x] Blackhole post-commit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033347995 - [ ] (Single-card) Model perf tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033439959 - [ ] (Single-card) Device perf regressions : https://github.com/tenstorrent/tt-metal/actions/runs/12033442095 - [x] (T3K) T3000 unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033456773 - [x] (T3K) T3000 demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033517770 - [x] (TG) TG unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033520415 - [x] (TG) TG demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033522422 - [x] (TGG) TGG unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033524632 - [x] (TGG) TGG demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12033526704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR similar to #15301. It previously broke CI pipelines, but this PR has a fix for that.
Ticket
Related to #13948
Problem description
Tied to UMD change tenstorrent/tt-umd#310
What's changed
Checklist