Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added GELU Op support #1125

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Added GELU Op support #1125

merged 1 commit into from
Nov 13, 2024

Conversation

azecevicTT
Copy link
Contributor

Closes #1061

tapspatel
tapspatel approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@tapspatel tapspatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test under test/Silicon/TTNN/perf_unit? Other than that, looks good!

@azecevicTT azecevicTT force-pushed the azecevic/gelu-op branch 2 times, most recently from 368fc3d to 50eb485 Compare October 31, 2024 16:09
@azecevicTT azecevicTT changed the title GELU Op implementation Added GELU Op support Nov 12, 2024
@azecevicTT azecevicTT enabled auto-merge (squash) November 13, 2024 12:01
@azecevicTT azecevicTT merged commit 9925638 into main Nov 13, 2024
17 checks passed
@azecevicTT azecevicTT deleted the azecevic/gelu-op branch November 13, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jserbedzijaTT jserbedzijaTT jserbedzijaTT approved these changes

@jnie-TT jnie-TT jnie-TT approved these changes

@sdjordjevicTT sdjordjevicTT sdjordjevicTT approved these changes

@tapspatel tapspatel tapspatel approved these changes

@kmabeeTT kmabeeTT Awaiting requested review from kmabeeTT kmabeeTT is a code owner

@AleksKnezevic AleksKnezevic Awaiting requested review from AleksKnezevic AleksKnezevic is a code owner

@pilkicTT pilkicTT Awaiting requested review from pilkicTT pilkicTT is a code owner

@svuckovicTT svuckovicTT Awaiting requested review from svuckovicTT svuckovicTT is a code owner

@rpavlovicTT rpavlovicTT Awaiting requested review from rpavlovicTT

@mtopalovicTT mtopalovicTT Awaiting requested review from mtopalovicTT mtopalovicTT is a code owner

@nobradovictt nobradovictt Awaiting requested review from nobradovictt nobradovictt is a code owner

@nsmithtt nsmithtt Awaiting requested review from nsmithtt nsmithtt is a code owner

@mrakitaTT mrakitaTT Awaiting requested review from mrakitaTT mrakitaTT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ops] Support for gelu op (ttnn.gelu)
5 participants
@azecevicTT @tapspatel @sdjordjevicTT @jnie-TT @jserbedzijaTT