Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9208: Functional SqueezeBERT model Demo #9371

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

kkeerthana0573
Copy link
Contributor

@kkeerthana0573 kkeerthana0573 commented Jun 11, 2024

Ticket

Problem description

  • Functional SqueezeBERT model Demo.

What's changed

  • TTNN support for SqueezeBERT model.
  • Added demo for SqueezeBertForQuestionAnswering task.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

Links to the passing CIs (09/12/2024):

@kkeerthana0573 kkeerthana0573 force-pushed the keerthana/functional_squeezebert_ branch from b3f15cf to 6f6a917 Compare June 12, 2024 10:59
@tt-rkim
Copy link
Collaborator

tt-rkim commented Nov 20, 2024

I don't see the post.

@kkeerthana0573
Copy link
Contributor Author

@tt-rkim,
The CI was passing for squeezebert here. Do you suspect any issue here?

@tt-rkim
Copy link
Collaborator

tt-rkim commented Nov 21, 2024

Isn't this squeeze bert test not found any tests? https://github.com/tenstorrent/tt-metal/actions/runs/11928473947/job/33245906399#step:9:2881

@kkeerthana0573
Copy link
Contributor Author

Squeezebert's device performance test on n300 passed here.

@tt-rkim
Copy link
Collaborator

tt-rkim commented Nov 22, 2024

Why are you not addressing the error I'm mentioning?

This line in your PR: https://github.com/tenstorrent/tt-metal/pull/9371/files#diff-17b43eb99e1634341d15c11cff11877200bdc21c12d4a70e05ad8630ac2117afR128

is causing a file not found error

@kkeerthana0573 kkeerthana0573 force-pushed the keerthana/functional_squeezebert_ branch 2 times, most recently from b34226e to e1b5527 Compare November 23, 2024 07:55
@kkeerthana0573
Copy link
Contributor Author

@tt-rkim
Copy link
Collaborator

tt-rkim commented Nov 27, 2024

Please update the threshold:

models.perf.device_perf_utils:check_device_perf:67 - AVG DEVICE KERNEL SAMPLES/S 283.90111071341295 is outside of expected range (180.61399999999998, 191.786)

for your model

I will approve to unblock

@kkeerthana0573 kkeerthana0573 force-pushed the keerthana/functional_squeezebert_ branch 4 times, most recently from 78852ad to facf57a Compare November 28, 2024 06:58
@kkeerthana0573
Copy link
Contributor Author

@tt-rkim,
I've updated the threshold and updated the description with passing CI links.

@kkeerthana0573 kkeerthana0573 force-pushed the keerthana/functional_squeezebert_ branch from facf57a to f1904c7 Compare November 28, 2024 13:22
models/demos/squeezebert/demo/demo.py Show resolved Hide resolved
models/demos/squeezebert/demo/demo.py Outdated Show resolved Hide resolved
models/demos/squeezebert/demo/demo.py Outdated Show resolved Hide resolved
@kkeerthana0573 kkeerthana0573 force-pushed the keerthana/functional_squeezebert_ branch 3 times, most recently from 7684985 to ec1dca0 Compare December 4, 2024 12:17
@kkeerthana0573 kkeerthana0573 requested a review from a team as a code owner December 4, 2024 12:17
@kkeerthana0573 kkeerthana0573 force-pushed the keerthana/functional_squeezebert_ branch from ec1dca0 to 4b52abc Compare December 4, 2024 15:12
@uaydonat uaydonat self-requested a review December 7, 2024 02:50
@kkeerthana0573 kkeerthana0573 force-pushed the keerthana/functional_squeezebert_ branch from 4b52abc to 16bb4d4 Compare December 9, 2024 04:18
@kkeerthana0573 kkeerthana0573 merged commit 7768e89 into main Dec 9, 2024
175 of 177 checks passed
@kkeerthana0573 kkeerthana0573 deleted the keerthana/functional_squeezebert_ branch December 9, 2024 05:44
@kkeerthana0573
Copy link
Contributor Author

Updated description with passing CI links and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants