Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4003: Look further back in time per op file to see if we had a prior… #5037

Merged
merged 4 commits into from
May 22, 2024

Conversation

eyonland
Copy link
Contributor

… failure

@eyonland eyonland requested a review from arakhmati as a code owner January 31, 2024 05:35
@eyonland eyonland force-pushed the ttnn-4003-keep-prior-failures branch 4 times, most recently from d373069 to 7051709 Compare January 31, 2024 18:20
@eyonland eyonland requested a review from tt-rkim as a code owner January 31, 2024 18:20
@eyonland eyonland force-pushed the ttnn-4003-keep-prior-failures branch 2 times, most recently from 9d0c3dd to 63288e4 Compare February 7, 2024 22:14
@eyonland eyonland force-pushed the ttnn-4003-keep-prior-failures branch from 63288e4 to 93693c4 Compare February 12, 2024 22:22
@eyonland eyonland closed this Mar 11, 2024
@eyonland eyonland force-pushed the ttnn-4003-keep-prior-failures branch from 93693c4 to d1253da Compare March 11, 2024 20:04
@eyonland eyonland reopened this Mar 11, 2024
@eyonland eyonland force-pushed the ttnn-4003-keep-prior-failures branch 5 times, most recently from af77e73 to 5459004 Compare March 13, 2024 01:47
@eyonland eyonland force-pushed the ttnn-4003-keep-prior-failures branch 3 times, most recently from ba40c88 to 7fe50f3 Compare March 28, 2024 23:46
@tt-rkim
Copy link
Collaborator

tt-rkim commented Apr 17, 2024

Hey @eyonland
@warthog9 and I discussed what possible security issues could be going on here.

The conclusion is essentially that yes, while someone could put something nefarious into any build scripts, this would apply for anyone who has access to our codebase. Nothing specific about this build process should disrupt us.

I'll help with integrating into the docs build from here, and show you what it looks like after.

@tt-rkim
Copy link
Collaborator

tt-rkim commented Apr 26, 2024

  • Move the ttnn_sweeps directive before the actual sphinx make docs step in the GH workflow build
  • Get rid of the checked in sweeps rst and change ttnn_sweeps/index.rst to a placeholder file
  • Request a read token for GITHUB_TOKEN (lmk)
  • Ensure that generated rsts are properly formatted so build doesn't break
  • Ensure that people can still build locally with the ttnn_sweeps, but that the pipeline build correctly builds with ttnn_sweeps
  • You can verify the whole flow on CI by downloading the gh_pages artifact on branch and serving it to yourself on localhost with python -m http.server <PORT> in the unzipped build folder

cc: @vtangTT

@eyonland - @vtangTT will try looking at it today, but he is also working on priority cmake work. We will reconvene on infra team later today to look at progress. If this is urgent P0, please loop in Jason

@tt-rkim
Copy link
Collaborator

tt-rkim commented May 21, 2024

Why did you close this? We're actively working on it. @davorchap
Please read the actions more carefully next time to check if you should close.
I noticed you did this with a lot of other PRs. Thanks for doing that.

@tt-rkim tt-rkim force-pushed the ttnn-4003-keep-prior-failures branch from c36b7b7 to afbd5c3 Compare May 22, 2024 19:57
@tt-rkim tt-rkim merged commit 35236b6 into main May 22, 2024
5 checks passed
@tt-rkim tt-rkim deleted the ttnn-4003-keep-prior-failures branch May 22, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants