Skip to content

Commit

Permalink
#4003: Look further back in time per op file to see if we had a prior…
Browse files Browse the repository at this point in the history
… failure
  • Loading branch information
eyonland committed Feb 12, 2024
1 parent 4b39362 commit 93693c4
Show file tree
Hide file tree
Showing 45 changed files with 1,816 additions and 200 deletions.
4 changes: 2 additions & 2 deletions docs/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ DOCS_VERSION ?= latest
BRANCH = $(shell git rev-parse --abbrev-ref HEAD)

GITHUB_TOKEN ?= INSERT_TOKEN_HERE
TTNN_SWEEPS_DIR = $(HTMLDIR)/ttnn_sweeps
TTNN_SWEEPS_DIR = $(SOURCEDIR)/ttnn/sweeps

# Put it first so that "make" without argument is like "make help".
help:
Expand Down Expand Up @@ -46,7 +46,7 @@ ttnn_sweeps/check_directory:

ttnn_sweeps:
@echo "Note that GITHUB_TOKEN must be set before calling this"
@cd .. && python tests/ttnn/sweep_tests/build_html_sweep_results.py --dir docs/$(TTNN_SWEEPS_DIR) --token $(GITHUB_TOKEN)
@cd .. && python tests/ttnn/sweep_tests/build_rst_sweep_results.py --dir docs/$(TTNN_SWEEPS_DIR) --token $(GITHUB_TOKEN)

server:
@echo "Navigate to: \033[4;33mlocalhost:$(PORT)/index.html\033[0m"
Expand Down
1 change: 1 addition & 0 deletions docs/requirements-docs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ nbsphinx==0.9.3
sphinxcontrib-jquery==4.1
ipython==8.12.3
pandoc==2.3
tabulate==0.9.0
1 change: 1 addition & 0 deletions docs/source/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Welcome to TT-Metalium documentation!
ttnn/converting_torch_model_to_ttnn
ttnn/ops_perf_report
ttnn/dependencies/index.rst
ttnn/sweeps/index.rst

.. toctree::
:caption: Models
Expand Down
2 changes: 1 addition & 1 deletion docs/source/ttnn/onboarding.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ is that the long term benefits will help us maintain our objectives. Please foll
* When creating the branch, please follow the pattern of 'TTNN-<Issue Number>-<brief description>'. For example, if the issue is 4730, the branch name would be `TTNN-4730-concat-operation`
* Use the `fallback` reference implementation for the operation and implement the functionality.
* Add the documentation in the rst format for the operation under `ttnn documentation <https://github.com/tenstorrent-metal/tt-metal/tree/main/docs/source/ttnn/ttnn>`_
* Add sweep tests to the branch using the fallback implementation under `ttnn sweep tests <https://github.com/tenstorrent-metal/tt-metal/tree/main/tests/ttnn/sweep_tests/sweeps>`_
* Add :ref:`sweep tests<ttnn.sweep_tests>` to the branch using the fallback implementation under `ttnn sweep tests <https://github.com/tenstorrent-metal/tt-metal/tree/main/tests/ttnn/sweep_tests/sweeps>`_
3. Update the issue referencing the pull requests after verifying that all the sweep tests run as expected. A TTNN CODEOWNERS will review the PR and verify that the API is acceptable and that the sweep tests reflect the intended functionality.
4. If the pull request (PR) is accepted it will be merge into the main branch and a new branch should be created that adds the implementation.
* The fallback implementation for the Operation should be left and will continue to be used for op-by-op PCC comparisons when debugging models (see `--ttnn-enable-debug-decorator`).
Expand Down
12 changes: 12 additions & 0 deletions docs/source/ttnn/sweeps/acos.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
.. _ttnn.sweep_test_acos:

acos
====================================================================
==== ======== =========================================================================================== ============= ======== ======= ================= ============================================================================================================================== ==============================================================================================================================
.. status exception batch_sizes height width input_dtype input_memory_config output_memory_config
==== ======== =========================================================================================== ============= ======== ======= ================= ============================================================================================================================== ==============================================================================================================================
0 crashed Exception: ttnn.acos: Tensor must be of layout {<Layout.TILE: 1>}, but got Layout.ROW_MAJOR (1,) 384 1024 DataType.BFLOAT16 tt::tt_metal::MemoryConfig(memory_layout=TensorMemoryLayout::INTERLEAVED,buffer_type=BufferType::DRAM,shard_spec=std::nullopt) tt::tt_metal::MemoryConfig(memory_layout=TensorMemoryLayout::INTERLEAVED,buffer_type=BufferType::DRAM,shard_spec=std::nullopt)
1 crashed Exception: ttnn.acos: Tensor must be of layout {<Layout.TILE: 1>}, but got Layout.ROW_MAJOR (1,) 384 4096 DataType.BFLOAT16 tt::tt_metal::MemoryConfig(memory_layout=TensorMemoryLayout::INTERLEAVED,buffer_type=BufferType::DRAM,shard_spec=std::nullopt) tt::tt_metal::MemoryConfig(memory_layout=TensorMemoryLayout::INTERLEAVED,buffer_type=BufferType::DRAM,shard_spec=std::nullopt)
2 crashed Exception: ttnn.acos: Tensor must be of layout {<Layout.TILE: 1>}, but got Layout.ROW_MAJOR (1,) 1024 1024 DataType.BFLOAT16 tt::tt_metal::MemoryConfig(memory_layout=TensorMemoryLayout::INTERLEAVED,buffer_type=BufferType::DRAM,shard_spec=std::nullopt) tt::tt_metal::MemoryConfig(memory_layout=TensorMemoryLayout::INTERLEAVED,buffer_type=BufferType::DRAM,shard_spec=std::nullopt)
3 crashed Exception: ttnn.acos: Tensor must be of layout {<Layout.TILE: 1>}, but got Layout.ROW_MAJOR (1,) 1024 4096 DataType.BFLOAT16 tt::tt_metal::MemoryConfig(memory_layout=TensorMemoryLayout::INTERLEAVED,buffer_type=BufferType::DRAM,shard_spec=std::nullopt) tt::tt_metal::MemoryConfig(memory_layout=TensorMemoryLayout::INTERLEAVED,buffer_type=BufferType::DRAM,shard_spec=std::nullopt)
==== ======== =========================================================================================== ============= ======== ======= ================= ============================================================================================================================== ==============================================================================================================================
Loading

0 comments on commit 93693c4

Please sign in to comment.