Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cluster_id deterministic #334

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Make cluster_id deterministic #334

merged 1 commit into from
Nov 26, 2024

Conversation

broskoTT
Copy link
Contributor

Issue

No issue

Description

Related to tenstorrent/tt-metal#15411
While working on it, I realised that cluster_id can take whichever chip_id.
This change makes it deterministic, and choose always the smallest one

List of the changes

  • Always chose smallest number in set for cluster_id
  • Wrote a test which failed before this change
  • Minor other changes in test to make it not segfault on machine without cards.

Testing

Wrote a new CI test

API Changes

There are no API changes in this PR.

@broskoTT broskoTT requested a review from pjanevskiTT November 26, 2024 09:57
@broskoTT broskoTT enabled auto-merge (squash) November 26, 2024 10:48
@broskoTT broskoTT merged commit c231125 into main Nov 26, 2024
19 of 22 checks passed
@broskoTT broskoTT deleted the brosko/fixed_cluster_id branch November 26, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants