Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #588 [Feature Request] Add prefix for metrics exposed by Pr… #623

Merged
merged 4 commits into from
Jan 16, 2025
Merged

fix issue #588 [Feature Request] Add prefix for metrics exposed by Pr… #623

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9de0223
fix issue #588 [Feature Request] Add prefix for metrics exposed by Pr…
robaho Jan 7, 2025
b18a480
do not update version
robaho Jan 16, 2025
c5e0e21
use quoted string for prefix if exists
robaho Jan 16, 2025
df8f21a
Update charts/temporal/values.yaml
robaho Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/temporal/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ dependencies:
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.54.0
version: 0.55.0
robaho marked this conversation as resolved.
Show resolved Hide resolved
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 1.26.2
3 changes: 3 additions & 0 deletions charts/temporal/templates/server-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ data:
excludeTags:
{{- toYaml . | nindent 10 }}
{{- end }}
{{- if and (hasKey .Values.server.metrics "prefix") .Values.server.metrics.prefix }}
robaho marked this conversation as resolved.
Show resolved Hide resolved
prefix: {{ $server.metrics.prefix }}
{{- end }}
{{- with $server.config.prometheus }}
prometheus:
{{- toYaml . | nindent 10 }}
Expand Down
1 change: 1 addition & 0 deletions charts/temporal/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ server:
tags: {}
# Tags to be excluded in Prometheus metrics
excludeTags: {}
prefix:
robaho marked this conversation as resolved.
Show resolved Hide resolved
# Enable Prometheus ServiceMonitor
# Use this if you installed the Prometheus Operator (https://github.com/coreos/prometheus-operator).
serviceMonitor:
Expand Down