-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue #588 [Feature Request] Add prefix for metrics exposed by Pr… #623
Conversation
|
Thanks for adding this! We need this as well :) Just a heads up, I noticed the contribution guide says: |
@raymondregrello but the docs in the Chart.yaml state you should update it helm-charts/charts/temporal/Chart.yaml Line 40 in 81cc46d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes made as suggested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixed the lint failure.
Co-authored-by: Rob Holland <[email protected]>
Thanks for your contribution :) |
#623) * fix issue #588 [Feature Request] Add prefix for metrics exposed by Prometheus #588 --------- Co-authored-by: Rob Holland <[email protected]>
fix Issue #588 add prefix for metrics exposed by Prometheus
What was changed
added
server.metrics.prefix
to values.yamlWhy?
per feature request, and the prefix is helpful for complex installations
added configuration setting to values.yaml and ran
helm template
and ensured that the correct setting made its way to the proper section in the config map file.I don't think so, as the other settings are not in the readme.