Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #588 [Feature Request] Add prefix for metrics exposed by Pr… #623

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

robaho
Copy link
Contributor

@robaho robaho commented Jan 7, 2025

fix Issue #588 add prefix for metrics exposed by Prometheus

What was changed

added server.metrics.prefix to values.yaml

Why?

per feature request, and the prefix is helpful for complex installations

  1. closes 588
  2. How was this tested:
    added configuration setting to values.yaml and ran helm template and ensured that the correct setting made its way to the proper section in the config map file.
  3. Any docs updates needed?
    I don't think so, as the other settings are not in the readme.

@robaho robaho requested a review from a team as a code owner January 7, 2025 21:17
@CLAassistant
Copy link

CLAassistant commented Jan 7, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@raymondregrello
Copy link

Thanks for adding this! We need this as well :)

Just a heads up, I noticed the contribution guide says:
"Note: Please do not bump the Chart version as this is automated as part of our release process."

@robaho
Copy link
Contributor Author

robaho commented Jan 8, 2025

@raymondregrello but the docs in the Chart.yaml state you should update it

# This is the chart version. This version number should be incremented each time you make changes

charts/temporal/templates/server-configmap.yaml Outdated Show resolved Hide resolved
charts/temporal/Chart.yaml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@robaho robaho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes made as suggested

@robaho robaho requested a review from robholland January 16, 2025 01:53
Copy link
Contributor

@robholland robholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the lint failure.

charts/temporal/values.yaml Outdated Show resolved Hide resolved
@robaho robaho requested a review from robholland January 16, 2025 13:38
@robholland
Copy link
Contributor

Thanks for your contribution :)

@robholland robholland merged commit 839b63f into temporalio:main Jan 16, 2025
3 checks passed
robholland added a commit that referenced this pull request Jan 16, 2025
#623)

* fix issue #588 [Feature Request] Add prefix for metrics exposed by Prometheus #588

---------

Co-authored-by: Rob Holland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants