Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/avoid modify rule name epl if already unique (master) #653

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Fix/avoid modify rule name epl if already unique (master) #653

merged 3 commits into from
Mar 30, 2022

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Mar 30, 2022 •
edited
Loading

fix issue #654

Related with works done in telefonicaid/perseo-core#192 telefonicaid/perseo-core#192

An example of temporal rule is #411 (comment)

@AlvaroVega AlvaroVega requested a review from fgalan March 30, 2022 08:46
@AlvaroVega AlvaroVega requested a review from manucarrace March 30, 2022 08:46
fgalan
fgalan approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 451b509 into master Mar 30, 2022
@fgalan fgalan deleted the fix/avoid_modify_ruleName_epl_if_already_unique branch March 30, 2022 09:03
@fgalan fgalan mentioned this pull request Mar 30, 2022
Closed
@AlvaroVega AlvaroVega changed the title Fix/avoid modify rule name epl if already unique Fix/avoid modify rule name epl if already unique (master) Mar 30, 2022
@AlvaroVega AlvaroVega restored the fix/avoid_modify_ruleName_epl_if_already_unique branch March 30, 2022 13:29
@fgalan fgalan mentioned this pull request Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

@manucarrace manucarrace Awaiting requested review from manucarrace

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvaroVega @fgalan