Merge pull request #653 from telefonicaid/fix/avoid_modify_ruleName_e…

…pl_if_already_unique Fix/avoid modify rule name epl if already unique
telefonicaid · Mar 30, 2022 · 451b509 · 451b509
2 parents 4088e86 + 0584e20
commit 451b509
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/CHANGES_NEXT_RELEASE b/CHANGES_NEXT_RELEASE
@@ -1 +1 @@
-- Fix: preselect in ruleWithContext (#630)
+- Fix: avoid modify ruleName epl if already unique (#654)
diff --git a/lib/models/rules.js b/lib/models/rules.js
@@ -91,7 +91,10 @@ function postR2core(rule, callback) {
             eplRule = {};
         if (isTimedRule(rule)) {
             // Ensure ruleName in EPL text is in unique format: rule.name@service+subservice
-            rule.text = rule.text.replace(rule.name, myutils.ruleUniqueName(rule));
+            const uniqueNameRule = myutils.ruleUniqueName(rule);
+            if (!rule.text.includes(uniqueNameRule)) {
+                rule.text = rule.text.replace(rule.name, uniqueNameRule);
+            }
             context = {
                 name: myutils.contextNameTimedRule(rule),
                 text: myutils.contextEPLTimedRule(rule)
@@ -175,7 +178,10 @@ function putR2core(rules, callback) {
         if (rule.text) {
             if (isTimedRule(rule)) {
                 // Ensure ruleName in EPL text is in unique format: rule.name@service+subservice
-                rule.text = rule.text.replace(rule.name, myutils.ruleUniqueName(rule));
+                const uniqueNameRule = myutils.ruleUniqueName(rule);
+                if (!rule.text.includes(uniqueNameRule)) {
+                    rule.text = rule.text.replace(rule.name, uniqueNameRule);
+                }
                 rulesAndContexts.push({
                     name: myutils.contextNameTimedRule(rule),
                     text: myutils.contextEPLTimedRule(rule)
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		- Fix: preselect in ruleWithContext (#630)
		- Fix: avoid modify ruleName epl if already unique (#654)