Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support fail-fast for PipelineRun #7987

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

support fail-fast for PipelineRun #7987

wants to merge 1 commit into from

Conversation

chengjoey
Copy link
Member

@chengjoey chengjoey commented May 26, 2024 •
edited
Loading

Changes

allow task to be cancelled if a parallel task fails #7880

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

/kind feature

Release Notes

fail-fast for PipelineRun

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 26, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wlynch after the PR has been reviewed.
You can assign the PR to them by writing /assign @wlynch in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot requested review from afrittoli and dibyom May 26, 2024 10:44
@chengjoey
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2024
@chengjoey
Copy link
Member Author

/kind feature

@chengjoey
Copy link
Member Author 

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.2% -0.6
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 94.4% -2.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.2% -0.6
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 94.4% -2.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.2% -0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.2% -0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.2% -0.6
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 98.3% 99.2% 0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.2% -0.6
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 98.3% 99.2% 0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.2% -0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.2% -0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.2% -0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.2% -0.6
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 98.3% 99.2% 0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.2% -0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.2% -0.6

@chengjoey
support fast-fail for PipelineRun
e989b8c 
allow task to be cancelled if a parallel task fails tektoncd#7880

Signed-off-by: chengjoey <[email protected]>
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.2% -0.6

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.2% -0.6

@vdemeester
Copy link
Member

@chengjoey @tektoncd/core-maintainers should be have a TEP for this ? It's a small but impactful API change, hence my question.

One question that pops up is : Should it be only on PipelineRun or on Pipeline, or both ? As is it a runtime thing a definition thing or both ?

@chengjoey
Copy link
Member Author

@chengjoey @tektoncd/core-maintainers should be have a TEP for this ? It's a small but impactful API change, hence my question.

One question that pops up is : Should it be only on PipelineRun or on Pipeline, or both ? As is it a runtime thing a definition thing or both ?

@vdemeester ,When I tried to write TEP, I found that it was just a very small function, so I implemented the code first.

As for the second question, I think this API field should belong to the runtime. Pipeline defines the specific information of the task, so that a Pipeline can decide whether to make it fail-fast at runtime. If co-maintainers think that Both is better, I will modify the code to support both.

Finally, I originally wrote Examples, which caused many of the previous e2e tests to fail. Later I found that Examples could only be Succeed, haha

@vdemeester
Copy link
Member

@vdemeester ,When I tried to write TEP, I found that it was just a very small function, so I implemented the code first.

Yeah, I think it might be fine without a TEP indeed, but I'ld rather make sure we all are inlined 👼🏼

Finally, I originally wrote Examples, which caused many of the previous e2e tests to fail. Later I found that Examples could only be Succeed, haha

Yeah, one thing we could/should enhance 😛

@chengjoey chengjoey mentioned this pull request Aug 19, 2024
Open
@ThomasKoppensteiner
Copy link

@chengjoey and @vdemeester any update about this PR? Does anyone else need to approve this?

@chengjoey
Copy link
Member Author

@chengjoey and @vdemeester any update about this PR? Does anyone else need to approve this?

hi @ThomasKoppensteiner , see this tep, i have submitted a proposal. i need to wait for the proposal to be accepted, and then I may need to modify the current PR. please give us some more time because we hope that all features have complete proposals and documents.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2024
@tekton-robot
Copy link
Collaborator

@chengjoey: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester vdemeester mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli Awaiting requested review from afrittoli

@dibyom dibyom Awaiting requested review from dibyom

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chengjoey @tekton-robot @vdemeester @ThomasKoppensteiner