TEP-0158: pipeline fail fast #1162
Conversation
Signed-off-by: chengjoey <[email protected]>
tekton-robot
added
the
size/L
|
/kind tep |
tekton-robot
added
the
kind/tep
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
| 1. `true`: When a Task in the Pipeline fails, the Pipeline execution is stopped immediately. | ||
| 2. `false`: This is consistent with the current behavior. When a Task in a Pipeline fails, the Pipeline status changes to Failed, but other Tasks continue to execute. |
There was a problem hiding this comment.
This sounds like we have fail-fast half implemented... I think the two options ideally should be:
true: When something causes the pipeline run to fail, all running tasks are terminated immediatelyfalse: When something causes the pipeline run to fail, no new tasks are scheduled. Once all running tasks are finished, the pipeline is marked as failed
But I guess we could keep false to behave like it does today and perhaps change it as part of a separate effort.
It would be nice for this to have graceful termination of Tasks and we don't want to lose logs in case of fail fast
There was a problem hiding this comment.
It would be nice for this to have graceful termination of Tasks and we don't want to lose logs in case of fail fast
graceful termination has been implemented by feat/Cancel taskrun using entrypoint binary
and it will be promoted to default
TEP-0158: pipeline fail fast
support fail-fast for PipelineRun