Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken import of go.opentelemetry.io/otel to v1.21.0 #7465

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Dec 6, 2023

Changes

This PR includes 2 commits to bump the opentelemetry.io/otel pkg:

  • "Cleanup: migrate off deprecated trace.NewNoopTracerProvider()" migrates off the deprecated trace.NewNoopTracerProvider func to use what's provided in go.opentelemetry.io/otel/trace/noop.
  • "Fix broken import of go.opentelemetry.io/otel" This commits fixes the broken dependencies on go.opentelemetry.io/otel. It patches the tracing package with an updated tracingProvider to
    implement the embeddedTracingProvider with the provider in the go.opentelemetry.io/otel/trace/noop pkg.

/kind bug
fixes: #7464

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 6, 2023
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2023
@dibyom
Copy link
Member

dibyom commented Dec 13, 2023

@JeromeJu are you working on this right now? Or I think we can close this and come back when we really need to update otel

@JeromeJu
Copy link
Member Author

@JeromeJu are you working on this right now? Or I think we can close this and come back when we really need to update otel

Agreed. Since we have the workaround for concurrent modification error. Let's close this for now.

@JeromeJu JeromeJu closed this Dec 13, 2023
@JeromeJu JeromeJu reopened this Jan 5, 2024
@JeromeJu JeromeJu marked this pull request as ready for review January 5, 2024 15:26
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2024
@tekton-robot tekton-robot requested a review from abayer January 5, 2024 15:26
This commit migrates off the deprecated trace.NewNoopTracerProvider
func.

part of tektoncd#7464
This commits fixes the broken dependencies on go.opentelemetry.io/otel.
It patches the tracing package with an updated tracingProvider to
implement the embeddedTracingProvider with the provider in the noop pkg.

/bug
fixes: tektoncd#7464
@JeromeJu JeromeJu changed the title Fix broken import of go.opentelemetry.io/otel Fix broken import of go.opentelemetry.io/otel to v1.21.0 Jan 5, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2024
@chitrangpatel chitrangpatel added this to the Pipelines v0.56 milestone Jan 9, 2024
@Yongxuanzhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
@tekton-robot tekton-robot merged commit 62e2bea into tektoncd:main Jan 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken imports of go.opentelemetry.io/otel/sdk for 1.21.0
6 participants