-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken import of go.opentelemetry.io/otel to v1.21.0 #7465
Conversation
Skipping CI for Draft Pull Request. |
7eae21c
to
5520cad
Compare
@JeromeJu are you working on this right now? Or I think we can close this and come back when we really need to update otel |
Agreed. Since we have the workaround for concurrent modification error. Let's close this for now. |
This commit migrates off the deprecated trace.NewNoopTracerProvider func. part of tektoncd#7464
This commits fixes the broken dependencies on go.opentelemetry.io/otel. It patches the tracing package with an updated tracingProvider to implement the embeddedTracingProvider with the provider in the noop pkg. /bug fixes: tektoncd#7464
5520cad
to
8dc684d
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Changes
This PR includes 2 commits to bump the opentelemetry.io/otel pkg:
go.opentelemetry.io/otel/trace/noop
.go.opentelemetry.io/otel
" This commits fixes the broken dependencies on go.opentelemetry.io/otel. It patches the tracing package with an updated tracingProvider toimplement the embeddedTracingProvider with the provider in the
go.opentelemetry.io/otel/trace/noop
pkg./kind bug
fixes: #7464
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes