-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken imports of go.opentelemetry.io/otel/sdk for 1.21.0 #7464
Comments
cc @kmjayadeep as you might have more inputs on the implementation of tracerProvider. |
This commit migrates off the deprecated trace.NewNoopTracerProvider func. part of tektoncd#7464
This commits fixes the broken dependencies on go.opentelemetry.io/otel. It patches the tracing package with an updated tracingProvider to implement the embeddedTracingProvider with the provider in the noop pkg. /bug fixes: tektoncd#7464
This commit migrates off the deprecated trace.NewNoopTracerProvider func. part of tektoncd#7464
This commits fixes the broken dependencies on go.opentelemetry.io/otel. It patches the tracing package with an updated tracingProvider to implement the embeddedTracingProvider with the provider in the noop pkg. /bug fixes: tektoncd#7464
I'm working on updating to otel 1.21. It also deprecated jaeger exporter in favor of otel exporter, which makes the update not so-straightforward. Is this blocking anyone currently? |
Thanks for this! I think this PR also works fine for the bump, just failed the go coverage test IIUC.
I don't think this is a blocker at the moment. |
@kmjayadeep the bump to containerd "seems" blocked on this. |
A lot of dependabot PRs are blocked on this. For some reason, dependabot tries to update it with other dependencies, making them all fail (instead of just updating the ones). |
@vdemeester I will check my WIP PR once again and raise upstream in the next couple of days |
I can reopen this #7465 if it looks good. @vdemeester @kmjayadeep |
This commit migrates off the deprecated trace.NewNoopTracerProvider func. part of tektoncd#7464
This commits fixes the broken dependencies on go.opentelemetry.io/otel. It patches the tracing package with an updated tracingProvider to implement the embeddedTracingProvider with the provider in the noop pkg. /bug fixes: tektoncd#7464
The proper solution is to migrate jaeger to otel exporter and upgrade to 1.21. I have raised #7547 for this. @JeromeJu In your PR, jaeger exporter is from otel 1.17 and SDK is 1.21. I'm not sure if there will be any compatibility issues with that. But if it works without issues, I would suggest to go ahead with it and unblock others. I can rebase afterwards on my PR. 7547 will take longer to review and test anyway. |
This commit migrates off the deprecated trace.NewNoopTracerProvider func. part of #7464
This commits fixes the broken dependencies on go.opentelemetry.io/otel. It patches the tracing package with an updated tracingProvider to implement the embeddedTracingProvider with the provider in the noop pkg. /bug fixes: #7464
When we are trying to bump go.opentelemetry.io/otel/sdk from 1.19.0 to 1.21.0, the build test failure indicates the tracerProvider @HEAD has not implemented the interface from the upstream.
When looking into this, there seems to be 2 issues that need verification:
Originally posted by @JeromeJu in #7387 (comment)
The text was updated successfully, but these errors were encountered: