Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we have stopSidecar retryable? #7452

Closed
JeromeJu opened this issue Dec 1, 2023 · 1 comment · Fixed by #7467
Closed

Should we have stopSidecar retryable? #7452

JeromeJu opened this issue Dec 1, 2023 · 1 comment · Fixed by #7467
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/question Issues or PRs that are questions around the project or a particular feature

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Dec 1, 2023

Current Behaviour

When we stop sidecars at pod entrypoint, we are currently marking the TaskRun as failed once any Sidecar is not stopped as expected.

Expected Behaviour

We would want to examine whether it is possible to retry the stopSidecar process. This would lead to the questions:

  1. What are the conditions that we want to retry? And how we could determine on such conditions?
  2. Shall we simply enforce a certain # of retries on this?

Example use cases: the sideCar could not be stopped when resources hit concurrent modification error.
i.e. "Operation cannot be fulfilled on pods ; the object has been modified; please apply your changes to the latest version and try again."

/kind question

@JeromeJu JeromeJu added kind/question Issues or PRs that are questions around the project or a particular feature kind/bug Categorizes issue or PR as related to a bug. labels Dec 1, 2023
@JeromeJu JeromeJu self-assigned this Dec 5, 2023
@JeromeJu
Copy link
Member Author

JeromeJu commented Dec 6, 2023

One straightforward workaround of this for Tekton is to change the reconciler to not to return a permanent based on OptimisticLockErrorMsg. Spinning up a PR to fix, currently working on unblocking broken imports related with dependencies issue caused by #7388 & #7387 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/question Issues or PRs that are questions around the project or a particular feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant