feat: Add file extension type column to shared data card for files #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in order to accomodate the file type column
paulschreiber
requested changes
Mar 21, 2024
|
@knipec I recommend transforming the text to uppercase in the view layer. This also avoids the null dereference causing test failures. |
paulschreiber
approved these changes
Mar 21, 2024
3 tasks
knipec
added a commit
that referenced
this pull request
Apr 2, 2024
) Displaying the domain was tied to the info prop. The bug was caused when I removed/renamed info, such that it then only applied to files, and failed to pass the domain info through for links. The info concept is now replaced by InfoComponent -- whose implementation will differ for files and links, as they will show different info with different layouts. Fixes #1690 (which was caused by #1660) Commits: * fix: Display domain url for links in shared files again * refactor: create InfoComponent for Link and File, instead of conditional logic in Base * refactor: Wrap InfoComponent in a Grid item and change the file and link implementations with respect to that parent Grid item It's not quite a refactor because the spacing changes very slightly, but I'm just gonna call it a refactor. * chore: Clean up comments * test: Add test that the expected items are in the shared data entries for files and links * refactor: Change Grid container to React fragment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the "Shared Files and Links" section, shared files now display a column with the file extension type.
This addresses GitHub Issue #1551.
Checklist
Related Issues
Will file some other issues found in the process of looking at this, but not directly related. One on grid layout particulars, one on localization, and one on edit description save button.
Verification steps
Aside