fix: Display the domain url for links that was previously missing #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal logic in Base
…ink implementations with respect to that parent Grid item It's not quite a refactor because the spacing changes very slightly, but I'm just gonna call it a refactor.
… for files and links
knipec
changed the title
paulschreiber
approved these changes
Apr 1, 2024
|
Verified on staging by Derek. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Displaying the domain was tied to the
infoprop. The bug was caused when I removed/renamedinfo, such that it then only applied to files, and failed to pass the domain info through for links.The
infoconcept is now replaced byInfoComponent-- whose implementation will differ for files and links, as they will show different info with different layouts.Checklist
Related Issues
Fixes #1690
(which was caused by #1660)
Verification steps
See #1690