refactor: Membership list model for groups and landscapes #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2023
This was referenced Nov 22, 2023
josebui
force-pushed
the
refactor/membership-list-group-landscape
branch
from
c966dc1 to
c719975
Compare
paulschreiber
requested changes
Nov 28, 2023
josebui
force-pushed
the
refactor/membership-list-group-landscape
branch
from
fd7d369 to
f643ca4
Compare
paulschreiber
approved these changes
Nov 29, 2023
paulschreiber
approved these changes
Nov 29, 2023
josebui
force-pushed
the
refactor/membership-list-group-landscape
branch
from
3d71602 to
074dfdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a really big PR, but I organized the commits by section (for most of the changes) so ideally if you check commit by commit the changes isolated to specific components will be there so that you can chek the related changes, hopefully that is good enough to review this.
My suggestion is to start reviewing from 0302d4a and just go to e0432e7 if some context is needed for the usage of a function or component.
Checklist
Related Issues
Related PRs