refactor: Landscape membership list #1262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 1, 2023
paulschreiber
requested changes
Nov 2, 2023
Comment on lines
+67
to
+68
| const success = _.get('meta.requestStatus', data) === 'fulfilled'; | ||
| if (success) { |
There was a problem hiding this comment.
Suggested change
| const success = _.get('meta.requestStatus', data) === 'fulfilled'; | |
| if (success) { | |
| if (_.get('meta.requestStatus', data) === 'fulfilled') { |
There was a problem hiding this comment.
Looks like success is only used once. Is that correct?
There was a problem hiding this comment.
@paulschreiber Yes, it is just used once, I added the separate variable for readibility
src/landscape/landscapeUtils.js
Outdated
Comment on lines
154
to
155
| // Get bounding box from nominatim.openstreetmap.org if no areaPolygon data | ||
| // AreaPolygon is not present when the user decided to skip it. |
There was a problem hiding this comment.
issue: please explain in more detail.
src/landscape/landscapeUtils.js
Outdated
Comment on lines
142
to
144
| areaPolygon: landscape.areaPolygon | ||
| ? JSON.parse(landscape.areaPolygon) | ||
| : null, |
There was a problem hiding this comment.
questioN: do we need to wrap the parse in a try/catch?
src/landscape/landscapeSlice.js
Outdated
Comment on lines
509
to
512
| if (landscape.slug === slug) { | ||
| return valueGenerator(landscape); | ||
| } | ||
| return landscape; |
There was a problem hiding this comment.
see note below regarding membership.email.
| @@ -0,0 +1,48 @@ | |||
| import React, { useCallback } from 'react'; | |||
There was a problem hiding this comment.
issue: add copyright notice.
src/landscape/landscapeService.js
Outdated
| import { | ||
| ALL_PARTNERSHIP_STATUS, | ||
| MEMBERSHIP_ROLE_MEMBER, | ||
| } from './landscapeConstants'; |
There was a problem hiding this comment.
issue: do not use relative path.
josebui
force-pushed
the
refactor/lanscape-group-memberships
branch
2 times, most recently
from
12e4993 to
aefa45e
Compare
josebui
force-pushed
the
refactor/lanscape-group-memberships
branch
from
ee9bd4b to
26c74d2
Compare
Co-authored-by: Paul Schreiber <[email protected]>
Co-authored-by: Paul Schreiber <[email protected]>
Co-authored-by: Paul Schreiber <[email protected]>
Co-authored-by: Paul Schreiber <[email protected]>
Co-authored-by: Paul Schreiber <[email protected]>
Co-authored-by: Paul Schreiber <[email protected]>
Co-authored-by: Paul Schreiber <[email protected]>
Co-authored-by: Paul Schreiber <[email protected]>
Co-authored-by: Paul Schreiber <[email protected]>
josebui
force-pushed
the
refactor/lanscape-group-memberships
branch
from
26c74d2 to
472a8f7
Compare
|
The final PR is: #1317 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Landscape is using a group to handle the user memberships in this PR I changed it to use MembershipList to removing the dependency with Group.
With this PR there is some duplciation added for the components and functions that eventually will be removed when groups are changed to use membership list too.
Checklist
Related Issues
Related PRs