refactor: Landscape membership list #946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 1, 2023
josebui
force-pushed
the
refactor/landscape-group-membership-list
branch
from
ce52296 to
7628137
Compare
paulschreiber
requested changes
Nov 2, 2023
Comment on lines
+57
to
+58
| def default_validation_func(self): | ||
| return False |
There was a problem hiding this comment.
question: what is this for?
There was a problem hiding this comment.
@paulschreiber The function using this default is the fucntion to save memberships, since the collaboration app doesn't have all the context to enforce the validation a function can be passed from the app using it to add the needed validation, if no function is passed this will be used by default
| @@ -25,6 +26,7 @@ | |||
| ) | |||
| from apps.core.models.taxonomy_terms import TaxonomyTerm | |||
|
|
|||
| from ..landscape_collaboration_roles import ROLE_MANAGER | |||
There was a problem hiding this comment.
question: can this be done without ..?
| @@ -21,6 +21,8 @@ | |||
| from django.utils.translation import gettext_lazy as _ | |||
| from safedelete.models import SOFT_DELETE_CASCADE, SafeDeleteManager, SafeDeleteModel | |||
|
|
|||
| from .. import landscape_collaboration_roles | |||
There was a problem hiding this comment.
question: can this be done without a relative path?
terraso_backend/tests/graphql/mutations/test_landscape_membership_mutations.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Paul Schreiber <[email protected]>
Co-authored-by: Paul Schreiber <[email protected]>
Co-authored-by: Paul Schreiber <[email protected]>
…hip_mutations.py Co-authored-by: Paul Schreiber <[email protected]>
Co-authored-by: Paul Schreiber <[email protected]>
josebui
force-pushed
the
refactor/landscape-group-membership-list
branch
from
262ed82 to
52a15aa
Compare
|
Final PR: #997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Landscape is using a group to handle the user memberships in this PR I changed it to use MembershipList to removing the dependency with Group
Checklist
Related Issues
Related PRs