-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: surface cracking screen #850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrouxm
force-pushed
the
feat/surface-cracking
branch
from
February 9, 2024 02:17
7fc41f2
to
5086770
Compare
1 task
paulschreiber
requested changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: I compressed the image with TinyPNG. Remember to do that. (Weirdly, this one kept shrinking on subsequent runs. I gave up after a few.)
dev-client/src/screens/SoilScreen/components/SoilSurfaceScreen.tsx
Outdated
Show resolved
Hide resolved
@paulschreiber i did actually run this one through tinypng, didn't think to put it through again as i assumed it'd be idempotent |
shrouxm
force-pushed
the
feat/surface-cracking
branch
from
February 13, 2024 21:27
b606e46
to
f937550
Compare
Co-authored-by: Paul Schreiber <[email protected]>
shrouxm
force-pushed
the
feat/surface-cracking
branch
from
February 13, 2024 22:03
f937550
to
6ba7a74
Compare
paulschreiber
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the surface cracking screen. Note this is stacked on top of #849 and should be merged afterwards. The client shared version may need to be updated after techmatters/terraso-client-shared#278 is merged if that doesn't happen in #849.
Checklist
Related Issues
Fixes #473
Verification steps
User should be able to select vertical cracking options from soil screen. Data completion/requirements should display correctly.