Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: surface cracking screen #850

Merged
merged 11 commits into from
Feb 14, 2024
Merged

feat: surface cracking screen #850

merged 11 commits into from
Feb 14, 2024

Conversation

shrouxm
Copy link
Member

@shrouxm shrouxm commented Feb 9, 2024

Description

Implements the surface cracking screen. Note this is stacked on top of #849 and should be merged afterwards. The client shared version may need to be updated after techmatters/terraso-client-shared#278 is merged if that doesn't happen in #849.

Checklist

  • Corresponding issue has been opened

Related Issues

Fixes #473

Verification steps

User should be able to select vertical cracking options from soil screen. Data completion/requirements should display correctly.

@shrouxm shrouxm requested a review from paulschreiber February 9, 2024 02:14
@shrouxm shrouxm force-pushed the feat/surface-cracking branch from 7fc41f2 to 5086770 Compare February 9, 2024 02:17
@shrouxm shrouxm changed the base branch from main to feat/color February 9, 2024 02:18
Copy link
Member

@paulschreiber paulschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I compressed the image with TinyPNG. Remember to do that. (Weirdly, this one kept shrinking on subsequent runs. I gave up after a few.)

dev-client/src/translations/en.json Outdated Show resolved Hide resolved
@shrouxm
Copy link
Member Author

shrouxm commented Feb 13, 2024

@paulschreiber i did actually run this one through tinypng, didn't think to put it through again as i assumed it'd be idempotent

@shrouxm shrouxm force-pushed the feat/surface-cracking branch from f937550 to 6ba7a74 Compare February 13, 2024 22:03
Base automatically changed from feat/color to main February 13, 2024 22:06
@shrouxm shrouxm merged commit 01b6bc3 into main Feb 14, 2024
5 checks passed
@shrouxm shrouxm deleted the feat/surface-cracking branch February 14, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: vertical cracking option
3 participants