feat: add some fields (color, clay, cracking) #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 9, 2024
Merged
1 task
|
@paulschreiber nope! it is the most minor of issues, unrelated to this PR, which leads to exactly one redundant type annotation per codebase which consumes this library, but would take a bunch of time to figure out so it's not worth it, leaving a comment so a future engineer knows it's a known issue with unclear resolution |
paulschreiber
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds some fields from backend, exposes some enums in TS friendly format. Needs to be merged after techmatters/terraso-backend#1149 so we can update to the right client shared version on that repo's main branch.
Checklist
Related Issues
Needed for techmatters/terraso-mobile-client#849 and techmatters/terraso-mobile-client#850