Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide depth-edit modal behind permission check #1721

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

tm-ruxandra
Copy link
Contributor

Description

Hide the controls to edit depth intervals on sites behind a role-based permission check.

Checklist

  • Corresponding issue has been opened

Related Issues

#1494

Verification steps

Open a site's soil screen as a viewer and verify that the vertical "more" button is not visible. Open it as an owner, contributor, or manager and verify that it is still visible and opens the editing modal.

Copy link
Member

@paulschreiber paulschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. (Please update the test snapshot.)

@tm-ruxandra tm-ruxandra force-pushed the fix/soil-depth-roles branch from 2802a08 to 4e4bb4c Compare July 5, 2024 21:07
@tm-ruxandra tm-ruxandra merged commit 9da0087 into main Jul 5, 2024
9 checks passed
@tm-ruxandra tm-ruxandra deleted the fix/soil-depth-roles branch July 5, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants