Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend should hide site data entry for Viewers #1350

Closed
knipec opened this issue May 16, 2024 · 2 comments
Closed

Frontend should hide site data entry for Viewers #1350

knipec opened this issue May 16, 2024 · 2 comments
Assignees
Labels
bug Something isn't working Engineering permissions

Comments

@knipec
Copy link
Contributor

knipec commented May 16, 2024

Repro:

  1. Create a Project with a Site.
  2. Add another user (who you can log in as) to the project as a Viewer
  3. Log out and log in as that other user from the previous step
  4. Go to the site and one of the data entry screens (like slope > steepness)
    Expected: No UI that makes me think I can actually input data.
    Actual: A "Done" button. A button for manual entry that I can put numbers into but doesn't work. A slope meter button that... well on my machine it causes a crash but maybe that's just the state of my branch?

Additional info:

This is not as egregious because the permissions checks on the backend will prevent the changes from making it to the database. Apparently this also prevents selections from being reflected in the app UI, so that's nice behavior, but in a kinda hacky way.

But I shouldn't see editing-specific UI if I am in a role that cannot make edits. I believe this is the full list of such UI elements in the Site tabs that should be altered or removed for Viewers:

  • Slope > Steepness: (1) "Done" button, (2) "Manual" button, (3) "Slope meter" button
  • Slope > Shape: (1) "Done" button
  • Soil: (1) ... menu for each depth interval
  • Soil > Vertical Cracks: (1) dropdown, (2) grayed out "Done" button
  • Soil > Texture/Rock fragment: (1) Texture dropdown, (2) "Use guide" button?
  • Soil > Color: (1) "Enter values" button, (2) "Use guide" button, (3) button to take or upload a photo
  • Notes: (1) pencil icon to edit a site note
  • Also, something about the interaction between the frontend and backend seems to handle the Pressable images in the Rock Fragment, Slope Steepness, and Shape screens. But would be nice to have frontend code that makes it explicit.
@knipec knipec added this to LandPKS May 16, 2024
@github-project-automation github-project-automation bot moved this to Todo in LandPKS May 16, 2024
@DerekCaelin DerekCaelin added this to the LandPKS Backlog milestone May 17, 2024
@DerekCaelin DerekCaelin added bug Something isn't working needs triage labels Jul 26, 2024
@paulschreiber
Copy link
Member

paulschreiber commented Aug 5, 2024

Slope Steepness fixed with #1834
Soil … menu fixed with #1721
Notes pencil icon fixed with #1646

@paulschreiber paulschreiber moved this from Todo to In Progress in LandPKS Aug 5, 2024
@paulschreiber paulschreiber self-assigned this Aug 5, 2024
@paulschreiber paulschreiber moved this from In Progress to In Review in LandPKS Aug 6, 2024
@paulschreiber paulschreiber moved this from In Review to QA in LandPKS Aug 13, 2024
@DerekCaelin
Copy link
Contributor

This appears resolved!

@github-project-automation github-project-automation bot moved this from QA to Done in LandPKS Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Engineering permissions
Projects
Status: Done
Development

No branches or pull requests

3 participants