Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Set is first login value inside token #1195

Merged
merged 3 commits into from
Mar 19, 2024
Merged

feat: Set is first login value inside token #1195

merged 3 commits into from
Mar 19, 2024

Conversation

josebui
Copy link
Contributor

@josebui josebui commented Mar 11, 2024 •
edited
Loading

Description

  • Added parameter inside token to know if the user was created with a service

Checklist

  • Corresponding issue has been opened
  • New tests added

Related Issues

@josebui josebui self-assigned this Mar 11, 2024
@josebui josebui mentioned this pull request Mar 11, 2024
Merged
2 tasks
@josebui josebui marked this pull request as ready for review March 11, 2024 20:10
paulschreiber
paulschreiber requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@paulschreiber paulschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename created_with_service to something that indicates it is true only for new years and false for existing users. Please also add a comment to that effect.

@josebui josebui changed the title feat: Set created with service value inside token feat: Set is first login value inside token Mar 15, 2024
@josebui josebui force-pushed the fix/complete-user-profile branch from f5d8604 to 6c18827 Compare March 15, 2024 20:22
@paulschreiber paulschreiber merged commit 70dd3a9 into main Mar 19, 2024
7 checks passed
@paulschreiber paulschreiber deleted the fix/complete-user-profile branch March 19, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulschreiber paulschreiber paulschreiber approved these changes

Assignees

@josebui josebui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josebui @paulschreiber