Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Redirect user to complete profile after first login #1622

Merged
merged 22 commits into from
Mar 19, 2024
Merged

fix: Redirect user to complete profile after first login #1622

merged 22 commits into from
Mar 19, 2024

Conversation

josebui
Copy link
Contributor

@josebui josebui commented Mar 11, 2024 •
edited
Loading

Description

  • Redirect user to complete profile after first login
  • Stored a new value in local storage to know if the user has already viewed the profile page after the first login

Checklist

  • Corresponding issue has been opened
  • New tests added

Dependency

Related Issues

@josebui josebui self-assigned this Mar 11, 2024
@josebui josebui marked this pull request as ready for review March 11, 2024 20:10
@paulschreiber paulschreiber self-requested a review March 11, 2024 21:01
paulschreiber
paulschreiber requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@paulschreiber paulschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josebui Please add the missing translation.

@josebui josebui requested a review from paulschreiber March 12, 2024 16:05
@paulschreiber paulschreiber self-requested a review March 12, 2024 16:12
@josebui josebui force-pushed the fix/complete-user-profile branch from b7b2bf7 to c8c48bb Compare March 15, 2024 19:43
@josebui josebui requested a review from paulschreiber March 15, 2024 19:51
paulschreiber
paulschreiber reviewed Mar 15, 2024
View reviewed changes
src/account/accountProfileUtils.js Outdated Show resolved Hide resolved
src/account/components/RequireAuth.test.js Outdated Show resolved Hide resolved
src/account/components/RequireAuth.test.js Outdated Show resolved Hide resolved
src/account/components/RequireAuth.test.js Outdated Show resolved Hide resolved
src/account/components/RequireAuth.test.js Outdated Show resolved Hide resolved
src/account/components/AccountProfile.js Outdated Show resolved Hide resolved
@josebui josebui requested a review from paulschreiber March 19, 2024 14:56
@paulschreiber paulschreiber merged commit 8c3b52c into main Mar 19, 2024
9 checks passed
@paulschreiber paulschreiber deleted the fix/complete-user-profile branch April 10, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulschreiber paulschreiber paulschreiber approved these changes

Assignees

@josebui josebui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josebui @paulschreiber