Do not apply skip-unless-changed for cron triggers. #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afranchuk
force-pushed
the
skip-unless-changed-no-cron
branch
from
3a259b8 to
a570cc4
Compare
jcristau
reviewed
Nov 4, 2024
afranchuk
force-pushed
the
skip-unless-changed-no-cron
branch
from
a570cc4 to
6fbdc1f
Compare
|
Oh, I need to update the other tests! |
afranchuk
force-pushed
the
skip-unless-changed-no-cron
branch
2 times, most recently
from
d6a2880 to
09841fd
Compare
afranchuk
force-pushed
the
skip-unless-changed-no-cron
branch
from
09841fd to
0c47206
Compare
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Nov 21, 2024
…eviewers,ahal Mainly to pick up taskcluster/taskgraph#604 and taskcluster/taskgraph#606 Differential Revision: https://phabricator.services.mozilla.com/D229800
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 22, 2024
…eviewers,ahal Mainly to pick up taskcluster/taskgraph#604 and taskcluster/taskgraph#606 Differential Revision: https://phabricator.services.mozilla.com/D229800
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 26, 2024
…eviewers,ahal Mainly to pick up taskcluster/taskgraph#604 and taskcluster/taskgraph#606 Differential Revision: https://phabricator.services.mozilla.com/D229800 UltraBlame original commit: f97cba74e8bd9653347e416ada5e077da97d6c99
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 27, 2024
…eviewers,ahal Mainly to pick up taskcluster/taskgraph#604 and taskcluster/taskgraph#606 Differential Revision: https://phabricator.services.mozilla.com/D229800 UltraBlame original commit: f97cba74e8bd9653347e416ada5e077da97d6c99
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 27, 2024
…eviewers,ahal Mainly to pick up taskcluster/taskgraph#604 and taskcluster/taskgraph#606 Differential Revision: https://phabricator.services.mozilla.com/D229800 UltraBlame original commit: f97cba74e8bd9653347e416ada5e077da97d6c99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want a little more flexibility, we could add an additional optional parameter to turn this behavior on or off (there might be some utility in tasks that strictly only run if some files changed, so that you can trigger all tasks with cron and those will be optimized away).