Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove 'release_notifications' backward compat shim #378

Merged
merged 1 commit into from
Dec 5, 2023
Merged

refactor!: remove 'release_notifications' backward compat shim #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/taskgraph/transforms/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
from taskgraph.transforms import ( # noqa: Added for backwards compat
notify as release_notifications,
)
7 changes: 2 additions & 5 deletions test/test_transforms_notify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import pytest

from taskgraph.transforms import release_notifications
from taskgraph.transforms import notify

TASK_DEFAULTS = {
"description": "fake description",
Expand Down Expand Up @@ -200,7 +200,4 @@ def test_transforms(
expected_task = deepcopy(TASK_DEFAULTS)
expected_task.update(expected_task_output)

assert (
run_transform(release_notifications.transforms, task, config)[0]
== expected_task
)
assert run_transform(notify.transforms, task, config)[0] == expected_task