Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove 'release_notifications' backward compat shim #378

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

ahal
Copy link
Collaborator

@ahal ahal commented Dec 4, 2023

BREAKING CHANGE: removed taskgraph.transforms.release_notifications shim

@ahal ahal added the BREAKING CHANGE Backwards incompatible request that will require major version bump label Dec 4, 2023
@ahal ahal requested a review from a team December 4, 2023 21:48
@ahal ahal self-assigned this Dec 4, 2023
@ahal ahal requested a review from jcristau December 4, 2023 21:48
@ahal
Copy link
Collaborator Author

ahal commented Dec 4, 2023

This was tripping up the pre-commit autoupdate PR.. rather than figure out how to get it to ignore this, let's just remove it as now is a good time anyway.

BREAKING CHANGE: removed `taskgraph.transforms.release_notifications`
shim
Copy link
Contributor

@bhearsum bhearsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, one less Gecko-ism.

@ahal ahal merged commit 3896dc9 into taskcluster:main Dec 5, 2023
7 checks passed
@ahal ahal deleted the notify branch December 5, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE Backwards incompatible request that will require major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants