feat: MPC Jobs pallet #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewstone
reviewed
Nov 6, 2023
drewstone
reviewed
Nov 6, 2023
Co-authored-by: Salman Pathan <[email protected]>
drewstone
requested changes
Nov 6, 2023
There was a problem hiding this comment.
Awesome start @1xstj ! Looks great, left some comments for potential fixes before first merge. We should create more tasks to update the types for the jobs themselves, so they include the necessary parameters for an integration test, please do add to the checklist or create a new one if we'll wrap it up.
Closed
6 tasks
salman01zp
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #281