Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles pallet Implementation #286

Merged
merged 12 commits into from
Nov 7, 2023
Merged

Roles pallet Implementation #286

merged 12 commits into from
Nov 7, 2023

Conversation

salman01zp
Copy link
Contributor

@salman01zp salman01zp commented Nov 3, 2023

Summary of changes
Changes introduced in this pull request:

  • Roles pallet implementation
  • Implement RolesHandler trait for the pallet
  • Implement bond and unbonding logic
  • Add simple fixed amount slashing
  • Add tests

Note:

Will add validator checks and re-staking logic in separate PR

Reference issue to close (if applicable)

Closes #280

@salman01zp salman01zp marked this pull request as ready for review November 6, 2023 12:04
@salman01zp salman01zp requested a review from shekohex November 6, 2023 12:04
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good start, I would like you to take a look at the jobs PR to ensure we're following similar style here on docs, comments, formatting, abstractions, etc.

pallets/roles/src/lib.rs Show resolved Hide resolved
pallets/roles/src/lib.rs Outdated Show resolved Hide resolved
pallets/roles/src/lib.rs Outdated Show resolved Hide resolved
pallets/roles/src/lib.rs Outdated Show resolved Hide resolved
pallets/roles/src/lib.rs Show resolved Hide resolved
pallets/roles/src/tests.rs Outdated Show resolved Hide resolved
pallets/roles/src/tests.rs Outdated Show resolved Hide resolved
primitives/src/types/jobs.rs Show resolved Hide resolved
@salman01zp salman01zp requested a review from drewstone November 7, 2023 15:15
@drewstone drewstone merged commit 4179289 into main Nov 7, 2023
8 checks passed
@drewstone drewstone deleted the salman/roles-pallet branch November 7, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Roles Pallet
2 participants