github/workflows/{android,go_mod_tidy}: run on all PRs and on pushes to {main,release-branch/*} #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to {main,release-branch/*}
Previously, using * in branch filters prevented PR CI actions from running on prefixed branches
as release-branch/* because * only matches characters except for forward slashes. In this PR,
we remove the branch filter to ensure that Android builds and go mod tidy checks are executed
on all PRs, regardless of the target branch. Additionally, these checks will now run on pushes
to release-branch/*.
Fixes tailscale/corp#25313
Signed-off-by: Nick Khyl <[email protected]>
nickkhyl
force-pushed
the
nickkhyl/ci-on-all-prs
branch
from
4ed0a24 to
aa94e59
Compare
nickkhyl
added a commit
that referenced
this pull request
Dec 12, 2024
…to {main,release-branch/*} (#591)
Previously, using * in branch filters prevented PR CI actions from running on prefixed branches such as release-branch/* because * only matches characters except for forward slashes. In this PR, we remove the branch filter to ensure that Android builds and go mod tidy checks are executed on all PRs, regardless of the target branch. Additionally, these checks will now run on pushes to release-branch/*.
Fixes tailscale/corp#25313
Signed-off-by: Nick Khyl <[email protected]>
nickkhyl
added a commit
that referenced
this pull request
Dec 12, 2024
…to {main,release-branch/*} (#591)
Previously, using * in branch filters prevented PR CI actions from running on prefixed branches such as release-branch/* because * only matches characters except for forward slashes. In this PR, we remove the branch filter to ensure that Android builds and go mod tidy checks are executed on all PRs, regardless of the target branch. Additionally, these checks will now run on pushes to release-branch/*.
Fixes tailscale/corp#25313
Signed-off-by: Nick Khyl <[email protected]>
(cherry picked from commit 34a06be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, using
*in branch filters prevented PR CI actions from running on prefixed branches such asrelease-branch/*because*only matches characters except for forward slashes. In this PR, we remove the branch filter to ensure that Android builds and go mod tidy checks are executed on all PRs, regardless of the target branch. Additionally, these checks will now run on pushes torelease-branch/*.Fixes tailscale/corp#25313