Skip to content

Commit

Permalink
github/workflows/{android,go_mod_tidy}: run on all PRs and on pushes …
Browse files Browse the repository at this point in the history
…to {main,release-branch/*} (#591)

Previously, using * in branch filters prevented PR CI actions from running on prefixed branches such as release-branch/* because * only matches characters except for forward slashes. In this PR, we remove the branch filter to ensure that Android builds and go mod tidy checks are executed on all PRs, regardless of the target branch. Additionally, these checks will now run on pushes to release-branch/*.

Fixes tailscale/corp#25313

Signed-off-by: Nick Khyl <[email protected]>
  • Loading branch information
nickkhyl committed Dec 12, 2024
1 parent a9c84cb commit c24562b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ on:
push:
branches:
- main
- "release-branch/*"
pull_request:
branches:
- "*"
# all PRs on all branches

jobs:
build:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/go_mod_tidy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ on:
- main
- "release-branch/*"
pull_request:
branches:
- "*"
# all PRs on all branches

concurrency:
group: ${{ github.workflow }}-$${{ github.head_ref || github.run_id }}
Expand Down

0 comments on commit c24562b

Please sign in to comment.